Eggsac carrier bugfix #5059
Merged
Eggsac carrier bugfix #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
reviewed
Nov 28, 2023
code/modules/mob/living/carbon/xenomorph/mutators/strains/carrier/eggsac.dm
Outdated
Show resolved
Hide resolved
|
As per what harry posted on discord I think you need both 🆑 either as text or emojis for it to work |
Oh yea I didn't even notice one wasn't an emoji version! |
fira
approved these changes
Dec 1, 2023
realforest2001
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
So in one of various refactors of #4716 I removed some important code from
Burst()for the new egg type which removes it from the carrier's sustained eggs. This is bad because we keep trying to call procs on eggs which have already burst etc.This removes the egg from the carrier's sustain list properly on Burst().
I also added a check in Life() on the carrier to remove it from their sustained eggs. If something funky happens we don't want to impact the player from playing
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Eggsack carrier eggs get properly removed from sustained list upon bursting.
/🆑